Add vpa crs for keda-operator and metrics-server#562
Add vpa crs for keda-operator and metrics-server#562QuantumEnigmaa wants to merge 4 commits intokedacore:mainfrom
Conversation
Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
|
I just noticed I forgot to sign my 2 previous commits :/ |
tomkerkhove
left a comment
tomkerkhove
left a comment
There was a problem hiding this comment.
Can you remove the new artifacts please?
Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
|
@tomkerkhove I reverted the changes on the artefacts |
|
|
||
| | Parameter | Type | Default | Description | | ||
| |-----------|------|---------|-------------| | ||
| | `autoscaling.verticalPodAutoscaler.keda.cpu.maxAllowed` | int | `2` | | |
There was a problem hiding this comment.
This is automatically generated though: https://github.com/kedacore/charts/blob/main/CONTRIBUTING.md#documentation
There was a problem hiding this comment.
Do you mean I can get rid of this change in the PR as it will be automatically be run by the ci jobs ?
|
I think that this is fascinating, but I'm not sure if it works correctly before the live pod resizing is in GA. I mean, restarting the operator for updating the pod size could produce scaling downtimes and we should clarify it IMHO. This also could generate impact on k8s api server on huge clusters if the VPA scales the pod so often because all the scalers cache has to be rebuilt on each restart, recovering all the needed info from the cluster |
|
@JorTurFer considering live pod resizing is closing on in GA, do you think it would be a good time to revive this PR? |
|
it's a good idea IMO, but probably we should open another PR from scratch based on this and including webhooks. |
4 participants
This PR adds VPA CRs for both
keda-operatorandmetrics-server.Checklist
Fixes #